修正版 #2
Open
修正版 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
server.cは、以下のレビューに対応
加えて、マルチスレッドにも挑戦 |
inazz
reviewed
Oct 11, 2024
| fprintf(stderr, "Failed to bind to any address\n"); | ||
| goto cleanup; | ||
| } | ||
| freeaddrinfo(res); |
There was a problem hiding this comment.
freeaddrinfo した後に res=NULL してあげて、２回目の解放を防ぐ。
| char buffer[BUFFER_SIZE]; | ||
| ssize_t bytes_read; | ||
| while ((bytes_read = read(client_socket, buffer, sizeof(buffer))) > 0) { | ||
| if (write(STDOUT_FILENO, buffer, bytes_read) < 0) { |
There was a problem hiding this comment.
標準出力に対して libc (printf など) と syscall を混ぜて使うと、
libc への printf がバッファされた結果、後からの write が先に出力されるなどの現象が起きるので、
混ぜて使わない。 (もしくはそのバッファリングまで意識したコードを書く (地獄))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.