-
-
Notifications
You must be signed in to change notification settings - Fork 789
presets: add zephyr
#4038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pi0
wants to merge
11
commits into
main
Choose a base branch
from
feat/zephyr-preset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
presets: add zephyr
#4038
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
579f8d3
presets: add `zephyr`
pi0 4194ee6
chore: apply automated updates
autofix-ci[bot] 90707d4
feat: zephyr preset that pulls cloud info from zephyr
Nsttt 7915de5
chore: cleanup and final touches
Nsttt f096648
chore: tighten types and async loading of zephyr-agent
Nsttt e3bd861
feat: make compatible with public paths
Nsttt c4268f9
Merge remote-tracking branch 'origin/main' into feat/zephyr-preset
Nsttt 29079ca
Merge branch 'main' into feat/zephyr-preset
pi0 fcce0b6
update lock
pi0 d3da97a
update
pi0 cb2ce55
Merge branch 'main' into feat/zephyr-preset
Nsttt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: nitrojs/nitro
Length of output: 320
🏁 Script executed:
Repository: nitrojs/nitro
Length of output: 7879
🏁 Script executed:
Repository: nitrojs/nitro
Length of output: 91
🌐 Web query:
zephyr-agent npm package documentation compatible version readDirRecursiveWithContents buildAssetsMap💡 Result:
zephyr-agentis published as an internal package and its npm README only documents the high-levelZephyrAgentAPI (it explicitly says it’s “not intended for direct use by end users”). It does not mention (or document)readDirRecursiveWithContentsorbuildAssetsMap, so there’s no “documentation-compatible version” you can reliably target for those symbols from the public docs. [1]If you’re trying to call those helpers directly, the safest conclusion is that they’re not part of the supported public API of
zephyr-agent(i.e., they may be private/internal, moved, or renamed across versions). In that case you should either:ZephyrAgent+ the asset map you build in your plugin), or.d.tsfor the specific version you’ve installed and pin that exact version.Also note: a similarly-named, documented assets-map helper exists in
zephyr-xpack-internal(buildWebpackAssetsMap), so you may be looking for a function that lives in a different package thanzephyr-agent. [2]Sources: npm
zephyr-agentREADME (v0.0.56) [1]; npmzephyr-xpack-internalREADME example (buildWebpackAssetsMap) [2].Pin
zephyr-agentto a specific version—the wildcard will break deploys.The code in
src/presets/zephyr/utils.tscalls internalzephyr-agentAPIs (readDirRecursiveWithContents,buildAssetsMap,zeBuildDashData,ZephyrEngine.create) that are not documented in the public API and may change across versions. A wildcard dependency cannot provide the stability this integration requires.The suggested pinning to
^0.1.13needs to be verified against the actualzephyr-agentpackage source or type definitions to confirm compatibility with the APIs being used. Check the package repository or installed types to determine the correct semver range.Suggested change
📝 Committable suggestion
🤖 Prompt for AI Agents