fix(cli): make SIGINT monitor shutdown handler async#26
Open
W4ilops wants to merge 1 commit into
Open
Conversation
|
@devwail is attempting to deploy a commit to the kaivocmenirehtacgmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Fixes a CLI startup syntax error by making the SIGINT shutdown handler asynchronous so it can legally use await import(...) within the monitor command flow.
Changes:
- Updated the
process.on('SIGINT', ...)handler in themonitorcommand to beasync, enablingawait import('../analytics/reputation.js').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a CLI syntax error in
src/cli/index.jscaused by usingawait import(...)inside a non-asyncSIGINTcallback.Type of change
skills/*/SKILL.md)Runtime context
Problem
The CLI failed before startup with:
The issue came from this pattern:
Root cause
awaitwas used inside a callback that was not markedasync.Fix
Changed the handler to:
Validation
Verified locally with:
Both commands worked successfully after the patch.