Skip to content

Release - 0.4.0 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mosharaf13 wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Release - 0.4.0 #47

mosharaf13 wants to merge 61 commits into from

Conversation

@mosharaf13
Copy link
Contributor

@mosharaf13 mosharaf13 commented Jun 26, 2023

mosharaf13 and others added 30 commits May 29, 2023 14:16
@mosharaf13
Add vendor in gitignore
3250d30
@mosharaf13
Show search stats in a table
ccfe931
@mosharaf13
[#14] Add search stat show page
09048a2
@mosharaf13
[#14] Add list of url's for adword and non-adwords
80f79ef
@mosharaf13
Add default per page for pagy
a8ab938
@mosharaf13
Use pagy default bootstrap pagination
6f2fc8a
@mosharaf13
Add render to search stats
fb6c01c
@mosharaf13
[#14] Show rendered search stat raw response in modal
39da3d2
@mosharaf13
Merge branch 'backend/list-keywords' into ui/list-keywords
d671f14
@mosharaf13
[#11] Remove extra blank lines
58915f9
@mosharaf13
[#11] Return search stats that belongs to user
6e67d79
@mosharaf13
[#11] Show search stat not found message
4c76675
@mosharaf13
Merge branch 'backend/list-keywords' into ui/list-keywords
65da6d4
@mosharaf13
[#40] Create separate model,migration, and seeder for result links
d57f29e
@mosharaf13
[#40] Show result links from db instead of dummy data
888c0d5
@mosharaf13
[#41] Sort models
08016c1
@mosharaf13
Merge branch 'backend/list-keywords' of github.com:mosharaf13/google-…
782ca46 
…scrapper-ruby into ui/list-keywords
@mosharaf13
Merge branch 'backend/list-keywords' into ui/list-keywords
5bd021c
@mosharaf13
Merge branch 'develop' into ui/list-keywords
4a7ee0f
@mosharaf13
Merge branch 'ui/list-keywords' of github.com:mosharaf13/google-scrap…
6a114a7 
…per-ruby into backend/create-storage-for-result-links
@mosharaf13
[#40] Remove ads_page link type from result link model
ad8a1a8
@mosharaf13 @sanG-github
Update db/migrate/20230601085414_create_result_links.rb
fcafc99 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13 @sanG-github
Update db/seeds.rb
5af96b7 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13 @sanG-github
Update app/views/search_stats/show.html.erb
81f148c 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13
[#40] Change type of link column in result_links table
3613756
@mosharaf13
Merge pull request #41 from mosharaf13/backend/create-storage-for-res…
7517322 
…ult-links

[Backend] As a system, I can have the capacity to store scrapped result links
@mosharaf13
[#11] Use active record model attributes in search stats table
57f9e8d
@mosharaf13
[#11] Add table for search stats
393df1f
@mosharaf13
[#11] Add active record based translation in search stat show page
a8a2755
@mosharaf13
[#11] Add search stat title
3a7ee71
mosharaf13 and others added 23 commits June 16, 2023 11:16
@mosharaf13
[#11] Add css :after for search stats details
8730d24
@mosharaf13
[#11] Fix style
9a8839b
@mosharaf13
[#11] Change style implementation for search stat detail
f3170c0
@mosharaf13
[#11] Change case for search stat detail class name
3b2cf62
@mosharaf13
[#11] Move raw response modal js file location
8079671
@mosharaf13
[#11] Change button element type in search stats table
78e96e5
@mosharaf13
[#11] Remove wrapping p tag from raw response button
f895479
@mosharaf13
[#11] Localise search stat ads and non ads title
055a969
@mosharaf13
[#11] Use bootstrap to show raw response modal
51725d5
@mosharaf13
[#11] Localise back button in search stat details page
47dd383
@mosharaf13
[#11] Remove unnecessary js file
b390c72
@mosharaf13
[#11] Localise no search stat found message
5bf2a10
@mosharaf13
[#11] Show only top ads in top ads section of search stat details
7060001
@mosharaf13 @sanG-github
[#11] Use single quote for rails string in detail page
af093c8 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13
[#11] Sort en.yml in alphabetical order
7ea2920
@mosharaf13
[#11] Create user explicitly in seeds.rb
d4b5083
@mosharaf13
[#11] Sanitize raw response before showing in modal
12b315e
@mosharaf13 @sanG-github
[#11] Update app/assets/stylesheets/application.scss
57eeabf 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13 @sanG-github
[#11] Update app/controllers/search_stats_controller.rb
0f869cc 
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
@mosharaf13
[#11] Add indentation in search stat details page
7c64ab6
@mosharaf13
[#11] Extract raw response modal iframe style to assets css
e896cb4
@mosharaf13
[#11] Fix lint
e11cd8e
@mosharaf13
Merge pull request #38 from mosharaf13/ui/list-keywords
4aa79c9 
[#11] [UI] As a user, I can list keywords, [#14] [UI] As a user, I can get keyword search result, [#13] [Backend] As a user, I can get keyword search result
@mosharaf13 mosharaf13 requested a review from a user June 26, 2023 04:53
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Code coverage is now at 0.00% (0/88 lines)

Generated by 🚫 Danger

sanG-github
sanG-github requested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@sanG-github sanG-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help to resolve the failing CI? 😜

@mosharaf13
Copy link
Contributor Author

mosharaf13 commented Jun 29, 2023

Could you please help to resolve the failing CI? 😜

This https://github.com/mosharaf13/google-scrapper-ruby/pull/48 PR solves the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanG-github sanG-github sanG-github requested changes

@longnd longnd Awaiting requested review from longnd

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mosharaf13 @sanG-github