Repository navigation
Play the tap sound only for taps, not for strokes - #13
Open
alcibiadesc wants to merge 1 commit into
Open
alcibiadesc wants to merge 1 commit into
alcibiadesc wants to merge 1 commit into
Conversation
The sound used to fire on mouse down, so every drawn line started with a click. It now waits for the release and plays only if no stroke began, using the same 4 pt threshold that starts the ink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the tap sound fires on mouse down, so every line you draw starts with a click, which sounds odd while sketching.
The sound now waits for the release and only plays if no stroke began. It uses the same 4 pt threshold that already decides when ink starts, so a tap still sounds and a drag stays silent. It's also cleared when the pointer turns off.
Trade-off: the tap sound now plays on mouse up instead of mouse down, a delay of roughly one click's duration.
🤖 Generated with Claude Code