refactor: replace GreetingUtil with a pipe for better testability #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for angular-authentication ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
nikosanif
requested changes
Apr 7, 2025
Owner
nikosanif
left a comment
nikosanif
left a comment
There was a problem hiding this comment.
Great contribution, @akib1997! Just a quick heads-up on a couple of minor changes to consider.
MeAkib
force-pushed
the
refactor/use-greeting-pipe
branch
from
99f10c1 to
24fe987
Compare
MeAkib
force-pushed
the
refactor/use-greeting-pipe
branch
from
24fe987 to
0a8281d
Compare
Contributor
Author
|
Sorry for late push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.