gaviota.py: simplify and improve code #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are apparently lines not covered by the tests that mypy was able to catch. I am open to modifying the code if it needs improvement. |
MarkZH
reviewed
Jan 6, 2025
Owner
|
Thanks, looks good! Will test offline with a larger test suite just to be sure. |
Owner
|
Found #1132 (happy if someone wants to take a look), but that's not a regression. So merging this. |
niklasf
added a commit
that referenced
this pull request
Feb 23, 2025
The resulting code is not equivalent, that is, when the full tablebase
is available ./test.py GaviotaTestCase fails with
ERROR: test_dm_4 (__main__.GaviotaTestCase.test_dm_4)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/niklas/Projekte/python-chess/./test.py", line 35, in _wrapper
return f(self)
File "/home/niklas/Projekte/python-chess/./test.py", line 4305, in test_dm_4
dtm = self.tablebase.probe_dtm(board)
File "/home/niklas/Projekte/python-chess/chess/gaviota.py", line 1393, in probe_dtm
dtm = self.egtb_get_dtm(req)
File "/home/niklas/Projekte/python-chess/chess/gaviota.py", line 1518, in egtb_get_dtm
dtm = self._tb_probe(req)
File "/home/niklas/Projekte/python-chess/chess/gaviota.py", line 1621, in _tb_probe
buffer_zipped = stream.read(z)
ValueError: read length must be non-negative or -1
Owner
|
There appears to be a suble way this is not equivalent, but I don't have the bandwidth to track it down at the moment. Reverted for now via 636e95f (see commit message for the problem). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @niklasf, I was having a look at the code to understand how endgame databases work and I saw that the Gaviota part of the code could be improved. Here is a first step:
The whole structure is the same so the PR should hopefully be easy enough to review. The tests pass and the code should also run faster.