Add declaration file to TypeScript#42
Open
Baskerville42 wants to merge 1 commit intonihgwu:masterfrom
Open
Conversation
|
Would be great if this could be merged, had a few issues guessing the correct types for props. |
Collaborator
|
@Baskerville42 thanks! I'll get to testing this when I have time in the next few days. If all is good, I'll merge |
Collaborator
Sorry, just saw this. I'll get it merged and deployed for you guys soon |
nihgwu
reviewed
Aug 26, 2020
Owner
nihgwu
left a comment
nihgwu
left a comment
There was a problem hiding this comment.
I'd prefer more accurate typings instead of all any
|
Would be great to see this in |
|
Why it's not in yet :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this error I propose to merge my PR with the declaration file for TS support
Related issue - #16