fix(config): add '\n' when writing to config files for POSIX compliance#5
Merged
night-slayer18 merged 1 commit intonight-slayer18:mainfrom Mar 10, 2026
Merged
Conversation
Owner
|
Thanks for the fix and for flagging the credentials.json issue! You're right that skipping it here makes sense since conf manages it differently. The underlying problem is that conf creates the file with 644 permissions, leaving the session cookie and CSRF token world-readable on multi-user systems. I'll follow up with a dedicated fix in credentials.ts — after each set() call, a chmodSync to 0o600 will lock it down to owner-only. I'll track this as a separate security issue. I've been meaning to fix with encryption as well. Merging this PR now — great catch on the POSIX compliance! |
night-slayer18
added a commit
that referenced
this pull request
Mar 10, 2026
- add breaking-change release notes for keychain-first credential storage and legacy plaintext deprecation - document backend selection env vars and windows powershell setup examples - update docker/headless auth guidance for env read-only mode - include merged PR #5 newline-formatting fix in release notes Signed-off-by: night-slayer18 <samanuaia257@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when running
caton TUI generated files such asconfig.jsonandworkspaces.json, they were missing newline characters at the end making them POSIX non-compliant. I haven't fixed this forcredentials.jsonas it relies on an external module and there's also a whole different issue pertaining to security.