Correct mirror mistake for RealSense and PrimeSense#4
Open
tansangxtt wants to merge 6 commits intoniessner:masterfrom
Open
Correct mirror mistake for RealSense and PrimeSense#4tansangxtt wants to merge 6 commits intoniessner:masterfrom
tansangxtt wants to merge 6 commits intoniessner:masterfrom
Conversation
added 2 commits
August 15, 2017 11:46
The method getSensorName has to been implemented due to inheritance from RGBDSensor
Lack of "new" while constructing
Szamo
reviewed
Oct 18, 2017
Szamo
left a comment
Szamo
left a comment
There was a problem hiding this comment.
I approve the changes, even if I do not have push right.
|
@tansangxtt RealSenseSensor.cpp/.h are missing, though? |
|
Yes, RealSenseSensor.cpp/.h are missing. However the modification has sense, it makes the code more uniform. It adds getSensorName to PrimeSenseSensor.h, and adds a RealSenseSensor object creator line to FriedLiver.cpp. You can say the RealSenseSensor files are missing, but the original code also fails in that case. These modifications are only fixes. Unfortunately I do not know where you can get RealSenseSensor files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are mirror errors however we will get stuck when enable them to build. This fixing is to make building fine