Fix rad upgrade kubernetes to preserve existing Helm release values#6
Merged
Fix rad upgrade kubernetes to preserve existing Helm release values#6
Conversation
- Changed pkg/cli/helm/cluster.go line 598 to use LastDeployed instead of FirstDeployed - Updated Test_Helm_GetRadiusRevisions_Success to use different timestamps for different revisions - Added comprehensive test Test_Helm_GetRadiusRevisions_MultipleUpgradesWithDifferentTimestamps - All tests pass successfully Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com>
…utput Fix revision timestamps in `rad rollback kubernetes --list-revisions` to show the list of all install times per version.
Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com>
Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com>
Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix issue 11218
Fix rad upgrade kubernetes to preserve existing Helm release values
Feb 11, 2026
…lues Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com>
nicolejms
approved these changes
Mar 2, 2026
nicolejms
pushed a commit
that referenced
this pull request
Mar 25, 2026
* Initial plan * Fix: Use LastDeployed instead of FirstDeployed for revision timestamps - Changed pkg/cli/helm/cluster.go line 598 to use LastDeployed instead of FirstDeployed - Updated Test_Helm_GetRadiusRevisions_Success to use different timestamps for different revisions - Added comprehensive test Test_Helm_GetRadiusRevisions_MultipleUpgradesWithDifferentTimestamps - All tests pass successfully Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com> * Merge pull request #2 from nicolejms/copilot/fix-revision-timestamp-output Fix revision timestamps in `rad rollback kubernetes --list-revisions` to show the list of all install times per version. * Merge branch 'main' into main * Merge branch 'main' into main * Merge branch 'radius-project:main' into main * Merge branch 'radius-project:main' into main * Merge branch 'radius-project:main' into main * Merge branch 'radius-project:main' into main * Merge branch 'radius-project:main' into main * new agent to investigate issues * Merge branch 'main' of https://github.com/nicolejms/radius * Initial plan * Add ReuseValues flag to Helm upgrade to preserve existing values Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com> * Add test and documentation for value preservation in upgrades Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com> * Address code review feedback with expanded test documentation Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com> * Add integration test to verify ReuseValues preserves existing Helm values Co-authored-by: nicolejms <101607760+nicolejms@users.noreply.github.com> * Merge remote-tracking branch 'origin/main' into copilot/fix-issue-11218
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rad upgrade kuberneteswas silently resetting non-default Helm values (e.g.,global.azureWorkloadIdentity.enabled,database.enabled, custom registries) to chart defaults. Values set during install via--setwere lost unless explicitly repeated on every upgrade.Changes
Core fix (
pkg/cli/helm/helmclient.go):upgradeClient.ReuseValues = trueinRunHelmUpgrade()--setoverridesTest coverage (
pkg/cli/helm/helmclient_test.go):azureWorkloadIdentity.enabled=truepreserved while applying newimageTagDocumentation (
pkg/cli/cmd/upgrade/kubernetes/kubernetes.go):Example
Before:
rad install kubernetes --set global.azureWorkloadIdentity.enabled=true rad upgrade kubernetes # azureWorkloadIdentity silently disabled ❌After:
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.