Feat(raylib renderer): Make utf8 work with raylib renderer#562
Open
Forelyl wants to merge 2 commits intonicbarker:mainfrom
Open
Feat(raylib renderer): Make utf8 work with raylib renderer#562Forelyl wants to merge 2 commits intonicbarker:mainfrom
Forelyl wants to merge 2 commits intonicbarker:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main problem was that firstly utf8 in raylib is been drawn in char* format
e.g cyrillic н is been represented as [208, 189] (Wiki - check 'Description' part)
So in short terms
fontToUse.glyphs[index]The second issue was that
int index = text.chars[i] - 32Reads only one char, while to decode utf-8 we need to read several of them
Third
Also added check on index to prevent out of bounds (if not all glyphs are loaded)