Fix Clay__GetParentElementId for new id scheme#521
Merged
nicbarker merged 1 commit intonicbarker:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
The name of the function is a bit misleading though. |
gradylink
added a commit
to ScratchEverywhere/ScratchEverywhere
that referenced
this pull request
Jan 22, 2026
fixed by adding changes from nicbarker/clay#521 to the patch
Owner
|
To prepare for the transition branch, I'm going to merge this in now and rebase it. Although as you mentioned, this function is going to be renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Clay__GetParentElementIdis now evaluated beforeClay__OpenElementWithId, the parent is now actually the current open element.Going to the "grandparent" as it is now will result in an id clash