Updates to nirfsg method and parameter names and defaults#2145
Merged
ni-jfitzger merged 5 commits intoni:masterfrom Dec 8, 2025
Merged
Updates to nirfsg method and parameter names and defaults#2145ni-jfitzger merged 5 commits intoni:masterfrom
ni-jfitzger merged 5 commits intoni:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
+ Coverage 90.01% 90.09% +0.07%
==========================================
Files 71 71
Lines 18637 18643 +6
==========================================
+ Hits 16776 16796 +20
+ Misses 1861 1847 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
reviewed
Dec 8, 2025
Collaborator
|
Can you remind me why there's no self_test system test? |
ni-jfitzger
requested changes
Dec 8, 2025
Co-authored-by: Jay Fitzgerald <34140133+ni-jfitzger@users.noreply.github.com>
ni-jfitzger
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
nametowaveform_nameinclear_arb_waveformandselect_arb_waveformto be consistent with other waveform methodsget_self_calibration_last_date_and_timetoget_self_cal_last_date_and_timeto be consistent with other MI driversmoduleparameter inget_self_cal_last_date_and_timeandget_self_calibration_temperaturemethods to align with documentation and allow duck-typingself_testto not have any parameters aligning with other MI driversself_test.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
Only build is tested to work. System tests were not run after the renaming.