Removing RFSG methods and properties which are not applicable#2143
Merged
ni-jfitzger merged 4 commits intoni:masterfrom Dec 8, 2025
Merged
Removing RFSG methods and properties which are not applicable#2143ni-jfitzger merged 4 commits intoni:masterfrom
ni-jfitzger merged 4 commits intoni:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
+ Coverage 89.17% 90.01% +0.84%
==========================================
Files 71 71
Lines 18960 18637 -323
==========================================
- Hits 16908 16777 -131
+ Misses 2052 1860 -192
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
reviewed
Dec 5, 2025
ni-jfitzger
approved these changes
Dec 5, 2025
Collaborator
ni-jfitzger
left a comment
ni-jfitzger
left a comment
There was a problem hiding this comment.
I don't see anything alarming in the removals and generally take no issue with removals from a beta API. We can always add things back later, if we need them. Just fix the changelog.
marcoskirsch
approved these changes
Dec 5, 2025
Updated CHANGELOG to reflect method and property removals, including those not supported anymore and those necessary for IVI compliance but not applicable for Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
No specific tests are run for the removed API.