NI-RFSG Fix gRPC metadata name mismatches#2136
Merged
ni-jfitzger merged 2 commits intoni:masterfrom Nov 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
+ Coverage 81.72% 89.18% +7.45%
==========================================
Files 29 71 +42
Lines 4115 18960 +14845
==========================================
+ Hits 3363 16909 +13546
- Misses 752 2051 +1299
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
Please look at the codecov results. Coverage should go up not down! |
marcoskirsch
approved these changes
Nov 6, 2025
Collaborator
This was probably just the result of not all system tests having run, at the time. It seems fixed, now. |
ni-jfitzger
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Updates NI-RFSG function metadata to prepare for upcoming gRPC support:
grpc_namefield where is a mismatch between expected gRPC parameter name and python name.grpc_enumfield where is a mismatch between expected gRPC enum name and python enum name.These changes are needed because
ni/grpc-devicehas already shipped with these parameter and enum names, and we can’t change them without breaking the API. Also the mismatch comes from us expanding the parameter/enum names when adding them to python API metadata.List issues fixed by this Pull Request
None
What testing has been done?
gRPC related fields in RFSG metadata are not consumed in the builds yet. These changes are prerequisite to allow us to enable gRPC codegen in upcoming PRs.