RFSG examples default value fix and clean up#2130
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 81.72% 89.18% +7.45%
==========================================
Files 29 71 +42
Lines 4115 18960 +14845
==========================================
+ Hits 3363 16909 +13546
- Misses 752 2051 +1299
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
marcoskirsch
left a comment
There was a problem hiding this comment.
I assume this matches other examples?
|
@marcoskirsch The option string default now aligns with other driver examples. However I do not see other drivers making resource name as required input. I made it required here mainly to catch it if its missing, at the example level itself instead of letting driver initialize error out. |
I think you should stay consistent. If you think making the resource name required, then make the change consistently in another PR. But I think many drivers allow leaving resource name blank in cases of simulation so that's probably why it's not required. |
|
Made the resource name to be not required to be consistent with other driver examples. Made the resource name default value to be PXI1Slot2 to be consistent with other driver examples. |
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
None
What testing has been done?