NI-FGEN: Update expected maximum_sequence_length in test_query_arb_seq_capabilities#2127
Merged
ni-jfitzger merged 2 commits intoni:masterfrom Aug 6, 2025
Merged
NI-FGEN: Update expected maximum_sequence_length in test_query_arb_seq_capabilities#2127ni-jfitzger merged 2 commits intoni:masterfrom
maximum_sequence_length in test_query_arb_seq_capabilities#2127ni-jfitzger merged 2 commits intoni:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2127 +/- ##
=======================================
Coverage 89.07% 89.08%
=======================================
Files 71 71
Lines 18960 18960
=======================================
+ Hits 16889 16890 +1
+ Misses 2071 2070 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
The value of
maximum_sequence_lengthwill be updated in the upcoming NI-FGEN release, hence this PR is to update the NI-FGEN system tests to simply verify thatmaximum_sequence_length>=minimum_sequence_lengthinstead of a specific value. This should be sufficient for an API test.That driver change is causing our internal nimi-python test events to fail, so we need this update to fix those failures.
What testing has been done?