NI-DCPower: Add API parity with NI-DCPower 2025 Q2#2102
Merged
ni-jfitzger merged 2 commits intoni:masterfrom May 30, 2025
Merged
NI-DCPower: Add API parity with NI-DCPower 2025 Q2#2102ni-jfitzger merged 2 commits intoni:masterfrom
ni-jfitzger merged 2 commits intoni:masterfrom
Conversation
- Update the metadata for NI-DCPower to 25.3.0f265 - Update the generated enums.py and session.py files as well as the docs files - Update CHANGELOG.md to call out the API parity changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.01%
==========================================
Files 66 66
Lines 16292 16318 +26
==========================================
+ Hits 14882 14909 +27
+ Misses 1410 1409 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
|
Nice catch with the 1.4.2 changelog fixes. |
ni-jfitzger
approved these changes
May 27, 2025
Collaborator
ni-jfitzger
left a comment
ni-jfitzger
left a comment
There was a problem hiding this comment.
@marcoskirsch Just some new properties and enum values. Probably nothing to debate here about whether something belongs in the API, etc.
marcoskirsch
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
What testing has been done?
Local run of tox was successful.
Local run of the system tests (
py312-nidcpower-system_tests) was also successful.