Eliminate use of dead and deprecated imports and options in setup.py#2070
Merged
ni-jfitzger merged 3 commits intoni:masterfrom Jan 26, 2025
Merged
Conversation
- Delete test cmdclass so that we don't break tox -e installers
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2070 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 66 66
Lines 16274 16274
=======================================
+ Hits 14864 14865 +1
+ Misses 1410 1409 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ni-jfitzger
commented
Jan 26, 2025
marcoskirsch
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Delete deprecated / unsupported imports and distribution options from setup.py. By doing this proactively, we can avoid being broken in the future.
According to GitHub Copilot,
setuptools.command.testprovides a way to setup for and run tests. It would happen in this case when users runpython setup.py test.The problems with that are:
tests_requireandtest_suite) are no longer recognized.For these reasons, it makes sense to just remove the import and everything related to it.
I also eliminated the setup_requires because it's considered deprecated and we won't be needing pytest-runner.
List issues fixed by this Pull Request below, if any.
What testing has been done?
PR Checks