Drop Python 3.8 Support

[ni-jfitzger]

• This contribution adheres to CONTRIBUTING.md.
• I've updated CHANGELOG.md if applicable.
• [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

• Drop Python 3.8 support, by removing it from our testing and list of officially supported versions.
• (For the first time) enforce our version support policy at installation: disallow installation of APIs on Python versions earlier than 3.9
  • As part of this we now need to specify a list of supported Python versions for building wheel_dep in tox-system_tests.ini

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

[ni-jfitzger]

Interestingly, our Changelog shows that we added 3.8 support to all APIs twice.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (afd791e) to head (7b69442).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   91.33%   92.04%   +0.71%     
==========================================
  Files          66       56      -10     
  Lines       16274    14652    -1622     
==========================================
- Hits        14864    13487    -1377     
+ Misses       1410     1165     -245     

Flag	Coverage Δ
codegenunittests	?
nidcpowersystemtests	94.59% <ø> (+0.04%)	⬆️
nidcpowerunittests	89.53% <ø> (ø)
nidigitalsystemtests	92.20% <ø> (ø)
nidigitalunittests	68.45% <ø> (ø)
nidmmsystemtests	92.72% <ø> (ø)
nifakeunittests	87.24% <ø> (ø)
nifgensystemtests	94.86% <ø> (ø)
nimodinstsystemtests	73.85% <ø> (ø)
nimodinstunittests	94.20% <ø> (ø)
niscopesystemtests	92.94% <ø> (ø)
niscopeunittests	43.20% <ø> (ø)
nisesystemtests	91.50% <ø> (ø)
niswitchsystemtests	82.03% <ø> (ø)
nitclksystemtests	94.87% <ø> (ø)
nitclkunittests	98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd791e...7b69442. Read the comment docs.

[marcoskirsch]

Weird about the duplication in CHANGELOG.md
If you have the energy to figure out what the right thing is (was it a different version of Python that was added? Second addition bogus) and fix it, that'd be great. You can do it in a separate PR if you prefer.

[ni-jfitzger]

Looks like the RHEL system tests are failing because it's trying to build nitclk with an older version of Python. I'll need to fix that.

[ni-jfitzger]

Weird about the duplication in CHANGELOG.md If you have the energy to figure out what the right thing is (was it a different version of Python that was added? Second addition bogus) and fix it, that'd be great. You can do it in a separate PR if you prefer.

We didn't do things as cleanly back then, but it seems as though support was officially added in 1.1.4 and we just forgot to add the classifier for PyPI until 1.2.0.