[RFC] Is type checking for the code generator worth it#1526
Open
texasaggie97-zz wants to merge 2 commits intomasterfrom
Open
[RFC] Is type checking for the code generator worth it#1526texasaggie97-zz wants to merge 2 commits intomasterfrom
texasaggie97-zz wants to merge 2 commits intomasterfrom
Conversation
Member
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add type hinting and checking for a subset of the code generator.
In particular, look at
metadata_add_all.pyandnimi_python_types.pyfor the major changes.Given how much needed to be torqued around to make this work, is it worth it to finish the rest of the code generator?
NOTE This does not add type checking or hinting to the public API.
List issues fixed by this Pull Request below, if any.What testing has been done?
Add
mypyin build_test tox environment