Merged
Conversation
Contributor
zhindes
approved these changes
Dec 16, 2025
bkeryan
reviewed
Dec 16, 2025
…/github.com/ni/nidaqmx-python into users/mprosser/task-3424643-waveform-toggle
bkeryan
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This sets the
WAVEFORM_SUPPORTFeature Toggle toCodeReadiness.RELEASE, and cleans up all the examples that were manually turning it on. Additionally, the digital waveform examples have been updated to take advantage of thewaveform.signals[]property.Why should this Pull Request be merged?
AB#3424643
What testing has been done?
All tests pass, all modified examples have been run.
Here's the output from the two digital waveform examples (which now use signals):