Skip to content

pyproject.toml: Fix PEP 660 builds by setting build-system to use poetry-core#722

Merged
bkeryan merged 2 commits intomasterfrom
users/bkeryan/fix-build-system
May 20, 2025
Merged

pyproject.toml: Fix PEP 660 builds by setting build-system to use poetry-core#722
bkeryan merged 2 commits intomasterfrom
users/bkeryan/fix-build-system

Conversation

@bkeryan
Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan commented May 19, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicabl
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Change the build system from poetry to poetry-core.

Why should this Pull Request be merged?

Enables clients to install the nidaqmx package in editable mode, outside of this project.

Without this, you get an error like:

pip install -e .
Obtaining file:///C:/dev/nidaqmx-python
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
ERROR: Project file:///C:/dev/nidaqmx-python has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. Since it does not have a 'setup.py' nor a 'setup.cfg', it cannot be installed in editable mode. Consider using a build backend that supports PEP 660.

What testing has been done?

cd $env:TEMP
python -m venv .edit_nidaqmx
.\.edit_nidaqmx\Scripts\pip.exe install -e C:\dev\nidaqmx-python\

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    34 files  ±0      34 suites  ±0   57m 14s ⏱️ -11s
 2 396 tests ±0   2 042 ✅ ±0    354 💤 ±0  0 ❌ ±0 
43 102 runs  ±0  36 850 ✅ ±0  6 252 💤 ±0  0 ❌ ±0 

Results for commit 04a8a18. ± Comparison against base commit c58d74d.

@bkeryan bkeryan merged commit 3b70f51 into master May 20, 2025
17 checks passed
@bkeryan bkeryan deleted the users/bkeryan/fix-build-system branch May 20, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants