Update pep8-naming and fix inconsistently named TypeVar#713
Merged
Conversation
Contributor
bkeryan
changed the title
zhindes
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
poetry update pep8-namingResolve the following failure:
pep8-naming is complaining that
_Dis covariant but it doesn't have a_cosuffix. This particular type variable doesn't really need to be covariant because the_read_and_copyfunction return type has exactly the same data type as the argument, so I removed thecovariant=True.Originally, this also failed because pep8-naming 0.15.0 didn't allow typevars to start with an underscore, but this was fixed in pep8-naming 0.15.1.
Why should this Pull Request be merged?
Fix an incorrect type variable.
What testing has been done?
Ran
poetry run nps lintandpoetry run mypy