feat: added support for non-unix docker endpoints#971
Conversation
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Docker host support by allowing non-unix endpoints while refactoring the Docker host parsing logic and updating related Traefik configurations. It also bumps the auth version in the example nhost configuration file.
- Support for non-unix Docker endpoints in getDockerHost() and traefik service.
- Dynamic setting of Docker endpoint and volumes based on the URL scheme.
- Update of auth.version in examples/myproject/nhost/nhost.toml.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/myproject/nhost/nhost.toml | Bumped auth.version from 0.37.1 to 0.40.0 |
| dockercompose/compose.go | Refactored getDockerHost() to return *url.URL and updated traefik service configuration for non-unix endpoints |
Comments suppressed due to low confidence (1)
dockercompose/compose.go:224
- [nitpick] The function name 'trafikFiles' appears inconsistent with 'traefik' used elsewhere; consider renaming it to 'traefikFiles' for clarity and further consistency.
if err := trafikFiles(dotnhostfolder); err != nil {
User description
Fixes #970
PR Type
Enhancement
Description
Added support for non-unix Docker endpoints in
DOCKER_HOSTRefactored Docker host parsing to accept multiple schemes
Dynamically set Traefik Docker provider endpoint based on scheme
Updated example
nhost.tomlto newer auth versionChanges diagram
Changes walkthrough 📝
compose.go
Add support for tcp and other Docker host schemesdockercompose/compose.go
getDockerHost()to return a*url.URLand support non-unixschemes
nhost.toml
Bump auth version in example configurationexamples/myproject/nhost/nhost.toml
auth.versionfrom '0.37.1' to '0.40.0'