This repository was archived by the owner on Nov 8, 2021. It is now read-only.
Use relative path so that we properly apply --base-href.#61
Open
SamuelMS wants to merge 2 commits intongx-translate:masterfrom
Open
Use relative path so that we properly apply --base-href.#61SamuelMS wants to merge 2 commits intongx-translate:masterfrom
SamuelMS wants to merge 2 commits intongx-translate:masterfrom
Conversation
|
I have the same problem.. |
|
I just wanted to make the exact same pull-request. You might add changes to There is no reason for having a hardcoded path. |
MickL
approved these changes
May 15, 2019
|
@ocombe please accept |
markstein
approved these changes
Sep 26, 2019
markstein
left a comment
markstein
left a comment
There was a problem hiding this comment.
this is a mandatory change for relative context paths
tonio
added a commit
to geonetwork/geonetwork-ui
that referenced
this pull request
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements changes from #12, since they were backed out due to failing tests.
@ocombe Would you mind reviewing when you get a moment? Thanks!