Open
Conversation
Author
2025-09-08.18.16.13.mp4 |
Lexer747
reviewed
Oct 3, 2025
| PoweredStaves stave = PoweredStaves.getPoweredStaves(weaponId, curAnimation); | ||
| boolean matchesSpellbook = matchesSpellbook(curAnimation); | ||
| attackDelayHoldoffTicks = getWeaponSpeed(weaponId, stave, curAnimation, matchesSpellbook); | ||
| attackDelayHoldoffTicks = config.flinchingMode() ? 10 : getWeaponSpeed(weaponId, stave, curAnimation, matchesSpellbook); |
Contributor
There was a problem hiding this comment.
Flinching isn't always 10 ticks. The wiki seems to agree https://oldschool.runescape.wiki/w/Flinching that it can vary, maybe this should be configurable (N tick choice) or just smarter and implement what the wiki describes.
E.g. this wouldn't work for the scarab mage example the wiki gives, but being able to set it too 15 ticks would be a proper delay for that NPC.
There was a problem hiding this comment.
In that case, could we have a checkbox to enable flinching mode and a field to enter the number of ticks we want the timer to be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to the config for "flinching mode".
Instead counts down 10 ticks until you can attack next.
Closes #33
Closes #63
Closes #90