Tests: Adding split coverage for http and stream for ssl-handshake-rtt#40
Open
MozerBYU wants to merge 2 commits into
Open
Tests: Adding split coverage for http and stream for ssl-handshake-rtt#40MozerBYU wants to merge 2 commits into
MozerBYU wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The following are regression tests for ssl-handshake-rtt. See Nginx PR: nginx/nginx#1225. These ensure that the proposed ssl-handshake-rtt variable code additions to ngx_http_ssl_module.c, ngx_event_openssl.c and ngx_stream_ssl_module.c behaves as expected in the following test cases:
Tested systems
Alpine 3.18, Alpine 3.23.3, Debian 12.10, Debian 13, Fedora 40, Kali Linux 2026.1, RedHat Enterprise Linux 10.1, Rocky Linux 8.9/8.10, Rocky Linux 9.3/9.8, Rocky Linux 10.1, Ubuntu 24.04, Ubuntu 25.10, Ubuntu 26.04.
Note: due to local environmental setup problems Alma Linux 9, Alma Linux 10.1, FreeBSD 10, Windows Server 2019 Standard were attempted, but not tested.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).-> Note: did not see anything to update in README.md, and did not see a CHANGELOG.md to modify.