Test handling of leading and trailing spaces and tabs#37
Open
DemiMarie wants to merge 1 commit into
Open
Conversation
The standard requires that they be stripped in HTTP/1.x and rejected in HTTP/2 and HTTP/3. However, leading and trailing whitespace are instead stripped in HTTP/2 and HTTP/3 by default for compatibility reasons. The logic identical for HTTP/2 and HTTP/3, so have the HTTP/2 tests test stripping and the HTTP/3 tests test rejection. Also add tests that catch leading and trailing tabs not being stripped from HTTP/1.x field values. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
DemiMarie
force-pushed
the
strip-whitespace-test
branch
from
4708e7a to
c72fe5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The standard requires that they be stripped in HTTP/1.x and rejected in HTTP/2 and HTTP/3. However, leading and trailing whitespace are instead stripped in HTTP/2 and HTTP/3 by default for compatibility reasons. The logic identical for HTTP/2 and HTTP/3, so have the HTTP/2 tests test stripping and the HTTP/3 tests test rejection.
Also add tests that catch leading and trailing tabs not being stripped from HTTP/1.x field values.
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords in this PR's description or commit message.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).