feat(electron): generate a single electron preload script#86
Draft
schmidtk wants to merge 1 commit intongageoint:masterfrom
Draft
feat(electron): generate a single electron preload script#86schmidtk wants to merge 1 commit intongageoint:masterfrom
schmidtk wants to merge 1 commit intongageoint:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Electron don't seem to handle loading preload scripts from
session.setPreloadsproperly. The first time the app is loaded, these preload scripts are not loaded.This changes the resolver's Electron plugin to generate a preload script that loads the other preloads contributed by projects in the workspace. That allows the app to use
webPreferences.preload, which is the preferred way to load a preload script.This supplements ngageoint/opensphere-electron/pull/42.