TEMPLATE: add a fallback for new outputdir parameter#3798
Merged
mashehu merged 7 commits intonf-core:devfrom Mar 17, 2026
Merged
TEMPLATE: add a fallback for new outputdir parameter#3798mashehu merged 7 commits intonf-core:devfrom
mashehu merged 7 commits intonf-core:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mirpedrol
approved these changes
Oct 7, 2025
Member
mirpedrol
left a comment
mirpedrol
left a comment
There was a problem hiding this comment.
Changes look good, but should we add linting as the issue suggests? I think it would be better to postpone these PRs until we add the publish section in the workflow.
Member
|
what is the state of this? is it ready to be merged? |
Contributor
Author
|
what do you think @maxulysse |
Member
That's exactly what I did: |
maxulysse
reviewed
Mar 6, 2026
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
4 tasks
Member
|
is this ready to be merged now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes ##3707