Add Refgenie config file to pipeline template and CI testing that file is not manually changed.#2139
Closed
mirpedrol wants to merge 9 commits into
Closed
Add Refgenie config file to pipeline template and CI testing that file is not manually changed.#2139mirpedrol wants to merge 9 commits into
mirpedrol wants to merge 9 commits into
Conversation
Dev -> Master for v2.7.2
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2139 +/- ##
==========================================
+ Coverage 71.44% 71.53% +0.08%
==========================================
Files 77 77
Lines 8378 8378
==========================================
+ Hits 5986 5993 +7
+ Misses 2392 2385 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
🧹 spring cleaning message 🌷 This went stale since we need feedback from refgenie. I will now close the PR, can be revisited later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1084
Create a genomes.config.tpl file which will contain refgenie registry paths [WIP - we don't have all required genomes & assets refgenie/aws_igenomes#1]
Populate genomes.config to obtain the file with genome URLs [WIP] (to do after previous point)
Create a GHA which tests that genomes.config has not been modified manually.
Tested with nf-core/testpipeline#53
PR checklist
CHANGELOG.mdis updateddocsis updated