Allow relative sample size input in subsampling#149
Closed
nkongenelly wants to merge 1 commit intonf-core:devfrom
Closed
Allow relative sample size input in subsampling#149nkongenelly wants to merge 1 commit intonf-core:devfrom
nkongenelly wants to merge 1 commit intonf-core:devfrom
Conversation
Co-authored-by: agrima2010 Co-authored-by: kjelinjonas
Contributor
Author
|
Closed as it is handled in this other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code allows subsampling to work with relative numbers too as the initial implementation limited it to absolute number of reads (#50).
seqtk_sample module itself allows passing fractions as the sample_size thus only our schema has been updated here to allow both integers and floats
Fixes #60
Co-authored-by: agrima2010
Co-authored-by: kjelinjonas
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).