Skip to content

Address trivial review changes from PR #52#59

Merged
vinisalazar merged 10 commits into
nf-core:devfrom
vinisalazar:pr52-code-review-minor
May 12, 2026
Merged

Address trivial review changes from PR #52#59
vinisalazar merged 10 commits into
nf-core:devfrom
vinisalazar:pr52-code-review-minor

Conversation

@vinisalazar
Copy link
Copy Markdown
Collaborator

@vinisalazar vinisalazar commented May 12, 2026

Summary

Addresses the review comments from #52 (jfy133 and jonasscheid).

  • Fix ext.prefix ternary syntax in conf/modules.config — must be inside a single closure
  • modules/local/fmhfunprofiler/main.nf: fix fmhfuncprofiler typo → fmhfunprofiler, remove TODO comments, fix version string (was full container URL, now just version tag)
  • modules/local/fmhfunprofiler/tests/main.nf.test: remove TODO comments
  • modules/local/fmhfunprofiler/meta.yml: rewrite from stale BAM-centric template to correct inputs/outputs for fmhfunprofiler
  • docs/output.md: restore Nextflow boilerplate, convert warning heading to :::note admonition, remove --- separators, add FastQC output docs, add tool descriptions before each section, remove <details> dropdowns
  • docs/usage.md: convert all GitHub-flavoured admonitions ([!NOTE], [!WARNING], [!IMPORTANT], [!TIP]) to nf-core website admonitions (:::note, :::warning, :::tip); capitalise Mifaser heading

Not addressed (non-trivial)

  • Moving local humann/rgi/mifaser/diamond modules to nf-core/modules
  • Bioconda packaging for fmhfunprofiler
  • test_full.config with real data
  • Container policy (ghcr → quay)
  • nextflow_schema.json parameter default inconsistencies

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@vinisalazar vinisalazar changed the title Address easy/trivial review changes from PR #52 Address trivial review changes from PR #52 May 12, 2026
@vinisalazar vinisalazar force-pushed the pr52-code-review-minor branch from 2ac251c to f30f7f9 Compare May 12, 2026 05:28
@vinisalazar vinisalazar force-pushed the pr52-code-review-minor branch from f30f7f9 to 630bfc2 Compare May 12, 2026 06:12
@vinisalazar vinisalazar merged commit 292e231 into nf-core:dev May 12, 2026
15 of 16 checks passed
@vinisalazar vinisalazar deleted the pr52-code-review-minor branch May 12, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants