Address trivial review changes from PR #52#59
Merged
Conversation
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
2ac251c to
f30f7f9
Compare
f30f7f9 to
630bfc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review comments from #52 (jfy133 and jonasscheid).
ext.prefixternary syntax inconf/modules.config— must be inside a single closuremodules/local/fmhfunprofiler/main.nf: fixfmhfuncprofilertypo →fmhfunprofiler, remove TODO comments, fix version string (was full container URL, now just version tag)modules/local/fmhfunprofiler/tests/main.nf.test: remove TODO commentsmodules/local/fmhfunprofiler/meta.yml: rewrite from stale BAM-centric template to correct inputs/outputs for fmhfunprofilerdocs/output.md: restore Nextflow boilerplate, convert warning heading to:::noteadmonition, remove---separators, add FastQC output docs, add tool descriptions before each section, remove<details>dropdownsdocs/usage.md: convert all GitHub-flavoured admonitions ([!NOTE],[!WARNING],[!IMPORTANT],[!TIP]) to nf-core website admonitions (:::note,:::warning,:::tip); capitalise Mifaser headingNot addressed (non-trivial)
test_full.configwith real datanextflow_schema.jsonparameter default inconsistencies