[FIX] Correct logic for linear deduplication#296
Conversation
3.2.1 Release Candidiate
3.2.2 Release Candidiate
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logic error in linear deduplication where reads with the lowest MAPQ scores were being kept instead of the highest quality reads. The fix includes a version bump and changelog update to document the correction.
- Fixed logic error in linear deduplication functionality
- Updated version from 3.2.2 to 3.2.3
- Added changelog entry documenting the bug fix
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nextflow.config | Bumped version number from 3.2.2 to 3.2.3 |
| CHANGELOG.md | Added new version entry documenting the deduplication logic fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR is against the
|
|
Important to get this approved / pulled. Until that's done, we cannot trust the resulting scores... which stops us from understanding what TIP-seq peaks are. |
Fixes #293
The bug and its fix are all detailed in the issue above.
Additionally, handle case where an empty input (no alignments) is passed to LA dedup Python script.
PR checklist
NA
NA
NA
nf-core lint).NA: PR change does not affect existing lint status
nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.NA
docs/output.mdis updated.NA
CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).