[cli] Allow one or more positional path args#1967
Open
jameshadfield wants to merge 1 commit intomasterfrom
Open
[cli] Allow one or more positional path args#1967jameshadfield wants to merge 1 commit intomasterfrom
jameshadfield wants to merge 1 commit intomasterfrom
Conversation
The previous interface was slightly cumbersome - I often found myself wanting to source both datasets & narratives from some directory X and having to type in the rather long `--datasetDir X --narrativeDir X`, and often I'd misspell / pluralise the argument names; using a simple positional argument `X` is much nicer. The ability to use multiple directories is also functionality I've long wanted. The previous CLI interface is preserved in its entirety for backwards compatibility and is mutually exclusive with the new positional-args style.
jameshadfield
force-pushed
the
james/cli-path-improvements
branch
from
5e77e9d to
3bf1f72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous interface was slightly cumbersome - I often found myself wanting to source both datasets & narratives from some directory X and having to type in the rather long
--datasetDir X --narrativeDir X, and often I'd misspell / pluralise the argument names; using a simple positional argumentXis much nicer. The ability to use multiple directories is also functionality I've long wanted.The previous CLI interface is preserved in its entirety for backwards compatibility and is mutually exclusive with the new positional-args style.