Add types for JSON.metadata#1887
Draft
jameshadfield wants to merge 2 commits intomasterfrom
Draft
Conversation
nextstrain-bot
temporarily deployed
to
auspice-james-ts-oolbjqjaqswf8
jameshadfield
force-pushed
the
james/ts
branch
from
ce33cbd to
8db1b14
Compare
jameshadfield
temporarily deployed
to
auspice-james-ts-oolbjqjaqswf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this PR will ever be merged but here's an experiment I went on back in June to type the
AuspiceDatasetJSON.metadatastructure and let those types flow through Auspice. It was also an attempt to learn some TypeScript. Making a draft PR to better surface this work as we were discussing it in light of @victorlin's PR to type the Tree state / component: #1864 (comment).