Add periodic corner neighbours#77
Merged
TomMelt merged 39 commits intoneighbourhood_diagonalfrom Feb 10, 2026
Merged
Conversation
TomMelt
force-pushed
the
add-periodic-corner-nbrs
branch
from
98a1cca to
bbfc171
Compare
Merged
|
Changes overall look good to me. I will be adding some tests to see it running. I guess most changes are related to:
Is their something else that I missed? |
niravshah241
approved these changes
Nov 15, 2025
niravshah241
left a comment
niravshah241
left a comment
There was a problem hiding this comment.
Approved. One more test will be added (for top and bottom overlapping neighbour) in PR #76
TomMelt
commented
Nov 17, 2025
| } | ||
|
|
||
| int Partitioner::halo_corner_start(const Domain d1, const Domain d2, const Vertex vertex) | ||
| int Partitioner::halo_corner_start( |
Contributor
Author
There was a problem hiding this comment.
@niravshah241 just flagging, I didn't verify/test Partitioner::halo_corner_start() for periodic neighbours. So it might be incorrect.
* need to create arrays to store periodic neighbours * need to output these arrays in Partitioner::save_metadata * need to add tests (integration)
…rt, is_neighbour, is_corner_neighbour public members (which were private members earlier)
remove neighbour check logic from domain_overlap update comments in is_neighbour to reflect the changes in Partitioner we still check the halo_size is non-zero but this will always be true, so it is not a problem.
Co-authored-by: Joe Wallwork <22053413+joewallwork@users.noreply.github.com>
TomMelt
force-pushed
the
add-periodic-corner-nbrs
branch
from
f5b4781 to
7ea7ea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Periodic neighbours to metadata
This PR does the following:
TODO
Partitioner::save_metadata