Nmc/2721 the circle progress of the media slideshow is not centered in safari firefox#475
Open
suet-kei-chan wants to merge 2 commits into
Conversation
Remove CSS cx/cy properties on svg circle which are not supported in Safari and Firefox, and fix asymmetric height to ensure the progress ring renders correctly in all browsers.
Remove horizontal padding from play-pause button that was causing the pill border-radius to render as an oval instead of a circle on hover. Use flexbox centering instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.