nmc/5963-hide-footer-in-text-editor#473
Merged
Merged
Conversation
The footer was already hidden in the app but appears to still be visible on mobile web view. Adding explicit CSS to hide the footer and reset its height variable to 0 when data-handler="text" is active, to test and confirm the fix.
suet-kei-chan
changed the title
Contributor
|
The problematic footer is not inside the "#viewer" container. the footer in question is the main footer "#telekom-minimal-footer". |
The #telekom-minimal-footer is a fixed element in <body>, separate from the #viewer container. The previous fix incorrectly targeted .viewer__footer inside #viewer which had no effect on the visible footer. The correct fix uses :has() to detect when the viewer is actively open (data-handler attribute is set only when a file is open) and hides the #telekom-minimal-footer for all file types, preventing it from overlapping the viewer on mobile web.
memurats
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer was already hidden in the app but appears to still be visible on mobile web view. Adding explicit CSS to hide the footer and reset its height variable to 0 when data-handler="text" is active, to test and confirm the fix.