Skip to content

[stable-5.5.5] NMC/2253 - Context Menu Customisation #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
Closed

[stable-5.5.5] NMC/2253 - Context Menu Customisation #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ea885b
NMC 2253 - Context menu customisation changes
TSI-amrutwaghmare Oct 30, 2023
0bab518
NMC 2253 - Menu update after NC 5.0 Release
TSI-amrutwaghmare Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions iOSClient/Menu/NCViewer+Menu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ extension NCViewer {
// FAVORITE
// Workaround: PROPPATCH doesn't work
// https://github.com/nextcloud/files_lock/issues/68
if !metadata.lock {
if !metadata.lock, !metadata.isDirectoryE2EE{
actions.append(
NCMenuAction(
title: metadata.favorite ? NSLocalizedString("_remove_favorites_", comment: "") : NSLocalizedString("_add_favorites_", comment: ""),
Expand Down Expand Up @@ -97,9 +97,9 @@ extension NCViewer {
if !webView, metadata.canShare {
actions.append(.share(selectedMetadatas: [metadata], viewController: viewController))
}

//
// SAVE LIVE PHOTO
// PRINT
//
if let metadataMOV = NCManageDatabase.shared.getMetadataLivePhoto(metadata: metadata),
let hudView = viewController.tabBarController?.view {
Expand All @@ -124,13 +124,7 @@ extension NCViewer {
icon: utility.loadImage(named: "doc.viewfinder", colors: [NCBrandColor.shared.iconImageColor]),
action: { _ in
if self.utilityFileSystem.fileProviderStorageExists(metadata) {
NotificationCenter.default.post(
name: Notification.Name(rawValue: NCGlobal.shared.notificationCenterDownloadedFile),
object: nil,
userInfo: ["ocId": metadata.ocId,
"selector": NCGlobal.shared.selectorSaveAsScan,
"error": NKError(),
"account": metadata.account])
NotificationCenter.default.postOnMainThread(name: NCGlobal.shared.notificationCenterDownloadedFile, userInfo: ["ocId": metadata.ocId, "selector": NCGlobal.shared.selectorPrint, "error": NKError(), "account": metadata.account])
} else {
guard let metadata = NCManageDatabase.shared.setMetadatasSessionInWaitDownload(metadatas: [metadata],
session: NextcloudKit.shared.nkCommonInstance.sessionIdentifierDownload,
Expand All @@ -142,11 +136,19 @@ extension NCViewer {
)
)
}

//
// SAVE CAMERA ROLL
//
if !webView, metadata.isSavebleInCameraRoll {
actions.append(.saveMediaAction(selectedMediaMetadatas: [metadata]))
}


//
// RENAME
//
if !webView, metadata.isRenameable {
if !webView, metadata.isRenameable, !metadata.isDirectoryE2EE {
actions.append(
NCMenuAction(
title: NSLocalizedString("_rename_", comment: ""),
Expand Down Expand Up @@ -183,6 +185,11 @@ extension NCViewer {
)
)
}
// COPY IN PASTEBOARD
//
if !webView, metadata.isCopyableInPasteboard, !metadata.isDirectoryE2EE {
actions.append(.copyAction(selectOcId: [metadata.ocId]))
}

//
// PDF
Expand Down Expand Up @@ -242,7 +249,7 @@ extension NCViewer {
// DELETE
//
if !webView, metadata.isDeletable {
actions.append(.deleteAction(selectedMetadatas: [metadata], indexPaths: [], metadataFolder: nil, viewController: viewController))
actions.append(.deleteAction(selectedMetadatas: [metadata], indexPath: [], metadataFolder: nil, viewController: viewController))
}

viewController.presentMenu(with: actions)
Expand Down