fix: return error on Codex response.failed instead of treating as success#889
Open
henkedk wants to merge 8 commits intonextlevelbuilder:mainfrom
Open
fix: return error on Codex response.failed instead of treating as success#889henkedk wants to merge 8 commits intonextlevelbuilder:mainfrom
henkedk wants to merge 8 commits intonextlevelbuilder:mainfrom
Conversation
added 8 commits
April 13, 2026 10:38
Re-applied 4 local patches not yet upstream: - NoSandbox browser option (3 files) - Telegram Groups config wiring from DB - SharedKG context injection in bridge middleware - Softer confidentiality rules for owner diagnostics
- bridge_server.go: remove BridgeToolNames allowlist, register all tools from registry - message.go: add buildMessageOutMeta for forum topic/thread routing in proactive messages - agents.go: restrict_to_workspace comment fix from stash
…routing - team_tasks_lifecycle.go executeComplete: read local_key from task metadata instead of member agent context (which doesn't have the originating topic key) - gateway_consumer_post_turn.go: extract taskLocalKey from task metadata and include WithLocalKey in all three auto-complete/auto-fail broadcasts (agent error, loop-detector kill, auto-complete)
Previously task_number was scoped per (team_id, chat_id), allowing duplicate numbers across different chats in the same team. Fixed to be unique per team. - pg/teams_tasks.go: MAX query now uses WHERE team_id = $1 only - sqlitestore/teams_tasks.go: same fix for SQLite - migrations/000050: deduplicate existing rows + add UNIQUE(team_id, task_number) - sqlitestore/schema.sql: add idx_tt_team_number unique index
…n filterCLIEnv; wire --effort per agent
…LEVEL env when agent effort is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888
processSSEEventhad no return value, soresponse.failedwas handled in the same switch case asresponse.completed. Server-side Codex failures during generation were silently swallowed — no error, no retry, user got "...".Changes:
codexErrorDetailstruct tocodex_types.go(Code, Message fields)processSSEEventnow returnserrorresponse.failedseparated from success case, returns error with message/code from the failed responseChatStream→ think stage →formatAgentErrorReviewed by Lars (Codex). Approved — correct error propagation, no false-positive risk on legitimate empty responses.