fix(heartbeat): keep stable phase scheduling#857
Open
badgerbees wants to merge 1 commit intonextlevelbuilder:devfrom
Open
fix(heartbeat): keep stable phase scheduling#857badgerbees wants to merge 1 commit intonextlevelbuilder:devfrom
badgerbees wants to merge 1 commit intonextlevelbuilder:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep heartbeat runs on a stable phase by advancing from the previous scheduled slot instead of resetting to
now + intervalafter each run.The old bug was that late completions could drift the schedule and gradually bunch agents back together instead of preserving the per-agent spread.
Type
main)Target Branch
dev
Checklist
go build ./...passesgo build -tags sqliteonly ./...passes (if Go changes)go vet ./...passesgo test -race ./...cd ui/web && pnpm build(if UI changes)$1, $2(no string concat)internal/upgrade/version.go(if new migration)Test Plan
Validated the heartbeat scheduler with focused Go tests in
internal/store,internal/heartbeat, andinternal/gateway/methods. The new regression tests cover deterministic initial staggering, stable-phase advancement from the prior scheduled slot, and catch-up behavior when runs are late.