-
Notifications
You must be signed in to change notification settings - Fork 263
Feature branch for 3.0 update #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ns, so that each solutions pipeline runs stand-alone
… into gvda-hello-v3
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Nextflow linting complete! ❌ 1 files had 1 errors 💡 Tip: Click filename locations to go directly to that code. View all 1 issues
View formatting changes
|
- Update all error message outputs to match v2 parser format (compact format with Error file.nf:line:col: and visual markers) - Rename Section 1.5 from "Non-Fatal Syntax Warnings" to "Statements Outside Workflow Block" since this is now a hard error - Update Section 2.3 fix example: change path(file_name) to val(file_name) since the example files don't actually exist - Update buggy_workflow.nf exercise to show v2's "Range out of bounds" error message with explanation Tested all examples with NXF_SYNTAX_PARSER=v2 in Docker container. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
DevContainer setup (.devcontainer/setup.sh): - Build nf-test from main branch commit 350bb147a during container startup - This includes PR #336 which fixes process-level test compatibility with v2 parser - The fix replaces the `*input` spread operator (rejected by v2) with `input.toArray()` - Added TODO comment to remove once nf-test releases a version with this fix Documentation (docs/side_quests/nf-test.md): - Update nf-test version from 0.9.2 to 0.9.3 - Update error message for missing process input to match v2 parser output: "declares 1 input channel but 0 were specified" -> "declares 1 input but was called with 0 arguments" - Fix Section 3 test count from 3 to 4 (2 pipeline + 2 process tests) - Fix Section 3 output to show correct command (nf-test test .) Working files (side-quests/nf-test/main.nf): - Revert params syntax to match documentation (params.input_file = ...) Tested all examples with NXF_SYNTAX_PARSER=v2 in Docker container. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The training Docker image doesn't include Maven, so the nf-test build from source was failing silently. Now installs Maven first if not present. Also adds check-v2-compatibility.sh script with --fix option for manual repair of existing Codespaces. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Install Maven if not present before building nf-test - Clean up ~/.m2/repository after build to save disk space - Remove check-v2-compatibility.sh script (not needed) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes made after testing with NXF_SYNTAX_PARSER=v2: - Section 1.3: Change "no entry workflow" output from warning to failure admonition since v2 parser treats this as an error (exit code 1), and update message text to match actual output - Section 1.3: Remove -entry option examples and explanation since this CLI option is not supported with strict syntax; simplify to explain that the solution is creating an unnamed entry workflow - Takeaway section: Simplify entry points bullet - Summary section: Streamline entry points pattern to show unnamed entry workflows as the standard approach, with clearer code examples All tutorial steps verified working with v2 parser. Co-Authored-By: Claude <noreply@anthropic.com>
- Add "Strict Syntax Parser (v2)" section explaining to always set NXF_SYNTAX_PARSER=v2 when running Nextflow commands - Add syntax parser to environment output format - Add v2 parser note as first item in Notes section This ensures all tutorial walkthroughs validate against the strict syntax that will become the default in future Nextflow versions. Co-Authored-By: Claude <noreply@anthropic.com>
pinin4fjords
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some TODOs- did you intend to address these?
- Fix nxf_versions.md path: ../nxf_versions.md -> ../info/nxf_versions.md - Fix hello_nextflow config link: 06_hello_configuration.md -> 06_hello_config.md - Fix nf-test side quest link: nf_test.md -> nf-test.md (hyphen not underscore) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- docs/envsetup/02_local.md: ../nxf_versions.md -> ../info/nxf_versions.md - docs/hello_nextflow/00_orientation.md: ../nxf_versions.md -> ../info/nxf_versions.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nxf_versions.md: - Fix malformed front matter (add missing 'hide:' key) - Fix broken links to envsetup pages (add ../ prefix) - Fix broken image paths (add ../ prefix) - Fix "Don't hesitate" style pattern hello_pipeline.md: - Fix malformed front matter (add missing 'hide:' key) - Fix broken image paths (add ../ prefix) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add blank line before bullet list for proper prettier formatting. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ow-io/training into 3.0-feature-strict-syntax
…ow-io/training into 3.0-feature-strict-syntax
won't do
mribeirodantas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Nextflow part looks good! 🤩
d04fa48 to
395505c
Compare
Major update to training portal