Make background LSP requests wait for pending update#24
Open
bentsherman wants to merge 1 commit intomainfrom
Open
Make background LSP requests wait for pending update#24bentsherman wants to merge 1 commit intomainfrom
bentsherman wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Member
Author
|
In vscode, the document link request seems to be delayed long enough to stay up to date, but the symbol request is not. You can see this by showing the outline in the sidebar, then deleting a definition (e.g. function, process, workflow) in a script. The outline is updated "too soon" and still shows the missing definition. Similarly if you restore the definition, the outline gets updated too soon again and doesn't show the symbol. So it seems like this fix will mostly apply to document symbols. But it should still be applied to all background requests to be safe, since different editors might behave differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #23
When a delayed update is scheduled, "background" LSP requests like document link and document symbol will await that update, so that they don't receive stale information.
"Foreground" requests like hover hint, completion, goto definition, etc should either force-update or just query against the current state, so as to not keep the user waiting.