-
Notifications
You must be signed in to change notification settings - Fork 25
Whiteboard exapp #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whiteboard exapp #226
Conversation
1263282 to
a543800
Compare
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early comments and questions, but looks promising :)
a543800 to
5d9b774
Compare
f7f51f9 to
67c5c40
Compare
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
67c5c40 to
99fde52
Compare
| PORT: process.env.PORT || DEFAULT_PORT, | ||
| IS_DEV: Utils.parseBooleanFromEnv(process.env.IS_DEV), | ||
|
|
||
| SETUP_TYPE: process.env.SETUP_TYPE || DEFAULT_SETUP_TYPE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker: I'm wondering if we could detect this from any of the env variables that app_api injects so we don't need to set this explicitly on the docker image. I would prefer if we could have a single multi purpose docker image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a similar thing with the APP_PORT below, as the previously hardcoded one 23000 did not work if you had another ex app installed before.
| @@ -0,0 +1,24 @@ | |||
| # SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this extra file?
|
Tested and works well 👍 Before merging we should decide if we can wrap this into the existing docker image or if we need to build a separate one.
After merge
|
|
Closed. Move the future developments to #467 cc @juliusknorr @grnd-alt |
Steps to run: