Skip to content

Try to decode the userinfo response like a JWT #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julien-nc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Try to decode the userinfo response like a JWT #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion lib/Service/OIDCService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use OCA\UserOIDC\Db\Provider;
use OCA\UserOIDC\Helper\HttpClientHelper;
use OCA\UserOIDC\Vendor\Firebase\JWT\JWT;
use OCP\Security\ICrypto;
use Psr\Log\LoggerInterface;
use Throwable;
Expand All @@ -37,11 +38,34 @@ public function userinfo(Provider $provider, string $accessToken): array {
'Authorization' => 'Bearer ' . $accessToken,
],
];

try {
return json_decode($this->clientService->get($url, [], $options), true);
$userInfoResponse = $this->clientService->get($url, [], $options);
} catch (Throwable $e) {
$this->logger->error('Request to the userinfo endpoint failed', ['exception' => $e]);
return [];
}

// try to decode it like a JSON string
try {
return json_decode($userInfoResponse, true);
} catch (Throwable) {
$this->logger->debug('The userinfo response is not JSON');
}

// try to decode it like a JWT token
JWT::$leeway = 60;
try {
$jwks = $this->discoveryService->obtainJWK($provider, $userInfoResponse);
$payload = JWT::decode($userInfoResponse, $jwks);
$arrayPayload = json_decode(json_encode($payload), true);
$this->logger->debug('JWT Decoded user info response', ['decoded_userinfo_response' => $arrayPayload]);
return $arrayPayload;
} catch (Throwable $e) {
$this->logger->debug('Treating the userinfo response as a JWT token. Impossible to decode it:' . $e->getMessage());
}

return [];
}

public function introspection(Provider $provider, string $accessToken): array {
Expand Down
Loading