Skip to content

Fix deprecated logger usage in IMAP backend to ensure compatibility with newer Nextcloud versions #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0xd4n3t wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecated logger usage in IMAP backend to ensure compatibility with newer Nextcloud versions #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/IMAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function checkPassword($uid, $password) {
$uid = $pieces[0];
}
} else {
\OC::$server->getLogger()->error(
\OC::$server->get(\Psr\Log\LoggerInterface::class)->error(
'ERROR: User has a wrong domain! Expecting: '.$this->domain,
['app' => 'user_external']
);
Expand Down Expand Up @@ -111,7 +111,7 @@ public function checkPassword($uid, $password) {
$errorcode === 28) {
# This is not defined in PHP-8.x
# 28: CURLE_OPERATION_TIMEDOUT
\OC::$server->getLogger()->error(
\OC::$server->get(\Psr\Log\LoggerInterface::class)->error(
'ERROR: Could not connect to imap server via curl: ' . curl_strerror($errorcode),
['app' => 'user_external']
);
Expand All @@ -122,12 +122,12 @@ public function checkPassword($uid, $password) {
# 9: CURLE_REMOTE_ACCESS_DENIED
# 67: CURLE_LOGIN_DENIED
# 94: CURLE_AUTH_ERROR)
\OC::$server->getLogger()->error(
\OC::$server->get(\Psr\Log\LoggerInterface::class)->error(
'ERROR: IMAP Login failed via curl: ' . curl_strerror($errorcode),
['app' => 'user_external']
);
} else {
\OC::$server->getLogger()->error(
\OC::$server->get(\Psr\Log\LoggerInterface::class)->error(
'ERROR: IMAP server returned an error: ' . $errorcode . ' / ' . curl_strerror($errorcode),
['app' => 'user_external']
);
Expand Down