Skip to content

Conversation

@tintou
Copy link

@tintou tintou commented Nov 26, 2025

PHP is warning that "The use statement with non-compound name 'CurlHandle' has no effect". This makes the web updater fail to update when the warning is propagated.
Closes: #687

@tintou tintou force-pushed the tintou/no-use branch 4 times, most recently from 03cf714 to 3e3b861 Compare November 26, 2025 13:44
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

@tintou could you address the failing check ? :)
https://github.com/nextcloud/updater#developmentmaking-changes

@tintou tintou force-pushed the tintou/no-use branch 2 times, most recently from 8d31ff3 to ba65d17 Compare December 11, 2025 10:24
@tintou
Copy link
Author

tintou commented Dec 11, 2025

@skjnldsv It's not clear to me how to address this, I tried composer install, make updater.phar and make index.php with no luck
Edit: okay I had to update composer to the latest version
Edit2: it's still not that, I don't know

@tintou tintou force-pushed the tintou/no-use branch 2 times, most recently from e62e2b7 to b07059a Compare December 11, 2025 10:36
PHP is warning that "The use statement with non-compound name 'CurlHandle' has no effect".
This makes the web updater fail to update when the warning is propagated.

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
@Altahrim
Copy link
Collaborator

Hello @tintou,

Thank you for taking care of this.
There is also an error with Closure, but hidden by the header.
I am trying a different approach here as CLI updater doesn't have the issue: #703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

updater does not work when display_errors is on by accident

3 participants